Include all TypeScript files in development configuration #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
thechenky
approved these changes
Jul 10, 2019
Contributor
thechenky
left a comment
thechenky
left a comment
There was a problem hiding this comment.
Ah, we left out integration_tests, this is great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two config files for TypeScript:
tsconfig.release.jsonandtsconfig.json. The latter is always used for local development, as some editors (like VS Code) and tools don't handle non-default locations. Sincetsconfig.jsonis used by all of these tools, it's convenient to include all TypeScript files in it. Some of the files in the project were not included, namelyintegration_testdirectory.This PR changes the configuration so it includes all files, causing both TypeScript and TSLint to take
integration_testinto account. The PR is split in two commits: one that changes the configuration and fixes minor compilation errors and one with the output of TSLint autofixer.Code sample
Not relevant.